Client gametest threading tweaks #4304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I've tested this by throwing a RuntimeException on each of the threads just after the in_game_overworld screenshot. The test thread and client thread worked fine, but the server thread did not, producing this stack trace:
[12:29:54] [Test thread/ERROR] (fabric-client-gametest-api-v1) Client gametests failed with an exception
java.lang.NullPointerException: stackTrace[9]
at java.base/java.lang.Throwable.setStackTrace(Throwable.java:903) ~[?:?]
at knot/net.fabricmc.fabric.impl.client.gametest.ThreadingImpl.joinAsyncStackTrace(ThreadingImpl.java:261) ~[fabric-client-gametest-api-v1-1.0.0+3dfdebf604-dev.jar:?]
at knot/net.fabricmc.fabric.impl.client.gametest.ThreadingImpl.runTaskOnOtherThread(ThreadingImpl.java:195) ~[fabric-client-gametest-api-v1-1.0.0+3dfdebf604-dev.jar:?]
at knot/net.fabricmc.fabric.impl.client.gametest.ThreadingImpl.runOnServer(ThreadingImpl.java:179) ~[fabric-client-gametest-api-v1-1.0.0+3dfdebf604-dev.jar:?]
at knot/net.fabricmc.fabric.test.client.gametest.ClientGameTestTest.runTest(ClientGameTestTest.java:84) ~[testmodClient/:?]
at knot/net.fabricmc.fabric.impl.client.gametest.FabricClientGameTestRunner.lambda$start$0(FabricClientGameTestRunner.java:43) ~[fabric-client-gametest-api-v1-1.0.0+3dfdebf604-dev.jar:?]
at knot/net.fabricmc.fabric.impl.client.gametest.ThreadingImpl.lambda$runTestThread$1(ThreadingImpl.java:129) ~[fabric-client-gametest-api-v1-1.0.0+3dfdebf604-dev.jar:?]
at java.base/java.lang.Thread.run(Thread.java:1583) [?:?]
[12:29:54] [Render thread/ERROR] (FabricLoader) Minecraft has crashed!
net.fabricmc.loader.impl.FormattedException: java.lang.NullPointerException: stackTrace[9]
at net.fabricmc.loader.impl.FormattedException.ofLocalized(FormattedException.java:63) ~[fabric-loader-0.16.9.jar:?]
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:482) ~[fabric-loader-0.16.9.jar:?]
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) [fabric-loader-0.16.9.jar:?]
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) [fabric-loader-0.16.9.jar:?]
at net.fabricmc.devlaunchinjector.Main.main(Main.java:86) [dev-launch-injector-0.2.1+build.8.jar:?]
Caused by: java.lang.NullPointerException: stackTrace[9]
at java.base/java.lang.Throwable.setStackTrace(Throwable.java:903) ~[?:?]
at knot/net.fabricmc.fabric.impl.client.gametest.ThreadingImpl.joinAsyncStackTrace(ThreadingImpl.java:261) ~[fabric-client-gametest-api-v1-1.0.0+3dfdebf604-dev.jar:?]
at knot/net.fabricmc.fabric.impl.client.gametest.ThreadingImpl.runTaskOnOtherThread(ThreadingImpl.java:195) ~[fabric-client-gametest-api-v1-1.0.0+3dfdebf604-dev.jar:?]
at knot/net.fabricmc.fabric.impl.client.gametest.ThreadingImpl.runOnServer(ThreadingImpl.java:179) ~[fabric-client-gametest-api-v1-1.0.0+3dfdebf604-dev.jar:?]
at knot/net.fabricmc.fabric.test.client.gametest.ClientGameTestTest.runTest(ClientGameTestTest.java:84) ~[testmodClient/:?]
at knot/net.fabricmc.fabric.impl.client.gametest.FabricClientGameTestRunner.lambda$start$0(FabricClientGameTestRunner.java:43) ~[fabric-client-gametest-api-v1-1.0.0+3dfdebf604-dev.jar:?]
at knot/net.fabricmc.fabric.impl.client.gametest.ThreadingImpl.lambda$runTestThread$1(ThreadingImpl.java:129) ~[fabric-client-gametest-api-v1-1.0.0+3dfdebf604-dev.jar:?]
at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]
Edit: To clarify, the correct line number ClientGameTestTest.java:84 is still in there, but the NullPointerException when joining the stack traces doesn't seem right.
Throwing the exception after the server_in_game screenshot instead produced a very similar result, so this issue does not seem to be specific to the integrated singleplayer server.
Code to reproduce:
Singleplayer server:
{
enableDebugHud(context);
waitForWorldTicks(context, 200);
context.takeScreenshot("in_game_overworld", 0);
+ ThreadingImpl.runOnServer(() -> {
+ throw new RuntimeException("test");
+ });
}Dedicated server:
waitForWorldTicks(context, 20);
context.takeScreenshot("server_in_game", 0);
+ ThreadingImpl.runOnServer(() -> {
+ throw new RuntimeException("test");
+ });
try now |
|
It works now. |
modmuss50
approved these changes
Dec 17, 2024
modmuss50
added
bug
Alexander01998
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can review the commits one at a time to make it easier to review.